martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r572156538
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -31,21 +31,42 @@ namespace nifi {
namespace minifi {
namespace io {
+constexpr const char
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570167902
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -31,21 +31,41 @@ namespace nifi {
namespace minifi {
namespace io {
+constexpr const char
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570397304
##
File path: libminifi/test/unit/FileStreamTests.cpp
##
@@ -263,3 +267,75 @@ TEST_CASE("Read zero bytes") {
minifi::io::FileStream stream(uti
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570177419
##
File path: libminifi/test/unit/FileStreamTests.cpp
##
@@ -263,3 +267,75 @@ TEST_CASE("Read zero bytes") {
minifi::io::FileStream stream(uti
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570172849
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -114,17 +151,18 @@ int FileStream::read(uint8_t *buf, int buflen) {
}
if (!IsNullOrEmpt
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570172791
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -77,10 +101,16 @@ void FileStream::close() {
void FileStream::seek(uint64_t offset) {
s
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570168732
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -59,15 +79,19 @@ FileStream::FileStream(const std::string &path, uint32_t
offset, bool write
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570168547
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -31,21 +31,41 @@ namespace nifi {
namespace minifi {
namespace io {
+constexpr const char
martinzink commented on a change in pull request #987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/987#discussion_r570167902
##
File path: libminifi/src/io/FileStream.cpp
##
@@ -31,21 +31,41 @@ namespace nifi {
namespace minifi {
namespace io {
+constexpr const char