[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #617: Minificpp 897

phrocker commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307783519 ## File path: extensions/libmodbus/Libmodbus.vcxproj ## @@ -0,0 +1,188 @@ + Review comment: is this a derivative of what is

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #617: Minificpp 897

phrocker commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307725472 ## File path: CMakeSettings.json ## @@ -104,6 +104,10 @@ "cmakeCommandArgs": "", "buildCommandArgs": "-v -j8",