[GitHub] [nifi-minifi-cpp] phrocker commented on issue #584: minificpp-773

2019-06-07 Thread GitBox
phrocker commented on issue #584: minificpp-773 URL: https://github.com/apache/nifi-minifi-cpp/pull/584#issuecomment-499987854 @am-c-p-p Thank you for the contribution. In subsequent PRs would you mind rebasing from master instead of merging master into your branch? --

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #584: minificpp-773

2019-06-06 Thread GitBox
phrocker commented on issue #584: minificpp-773 URL: https://github.com/apache/nifi-minifi-cpp/pull/584#issuecomment-499477760 > I think we should create a follow-up ticket to make sure this code gets test coverage on Win. There is a branch with most tests built but had some pre-cond