[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r622296205 ## File path: controller/MiNiFiController.cpp ## @@ -167,9 +165,10 @@ int main(int argc, char **argv) { socket = secure_context != nullp

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r605665253 ## File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp ## @@ -85,8 +86,9 @@ void AbstractMQTTProcessor::onSchedule(const std::shared_p

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r607757072 ## File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp ## @@ -146,7 +148,7 @@ void AbstractMQTTProcessor::onSchedule(const std::shared

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r605576191 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -52,18 +52,6 @@ bool conversionTest(uint64_t number, core::TimeUnit unit, uint64_t check

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r605576191 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -52,18 +52,6 @@ bool conversionTest(uint64_t number, core::TimeUnit unit, uint64_t check