[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-04 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r645450031 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -127,8 +129,8 @@ core::Property

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644092746 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review comment:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644092746 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review comment:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-01 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r642561026 ## File path: extensions/coap/controllerservice/CoapConnector.h ## @@ -15,8 +15,12 @@ * See the License for the specific language governing