szaszm commented on a change in pull request #710: WIP: MINIFICPP - 1110,1111 -
PublishKafka, OPC processors should config and
URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r368467670
##########
File path: extensions/opc/src/fetchopc.cpp
##########
@@ -93,14 +93,12 @@ namespace processors {
translatedNodeIDs_.clear(); // Path might has changed during restart
- BaseOPCProcessor::onSchedule(context, factory);
-
- if(!configOK_) {
- return;
+ try {
+ BaseOPCProcessor::onSchedule(context, factory);
+ } catch (const Exception &e) {
+ throw e;
}
Review comment:
What's the intention behind these lines? We catch `minifi::Exception`s then
rethrow them without doing anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
