szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r476387922
##
File path: libminifi/test/unit/GeneralUtilsTest.cpp
##
@@ -0,0 +1,117 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one o
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r476331404
##
File path: libminifi/include/utils/OptionalUtils.h
##
@@ -37,11 +39,47 @@ optional::type>
optional_from_ptr(T&& obj) {
return obj == nullptr ?
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r476331404
##
File path: libminifi/include/utils/OptionalUtils.h
##
@@ -37,11 +39,47 @@ optional::type>
optional_from_ptr(T&& obj) {
return obj == nullptr ?
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r474207680
##
File path: libminifi/include/properties/Properties.h
##
@@ -82,6 +84,16 @@ class Properties {
*/
int getInt(const std::string &key, int def
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r473275694
##
File path: libminifi/src/DiskSpaceWatchdog.cpp
##
@@ -0,0 +1,96 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more