[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1360: MINIFICPP-1853 Enable multiple metrics from the same processor type

2022-08-15 Thread GitBox
szaszm commented on code in PR #1360: URL: https://github.com/apache/nifi-minifi-cpp/pull/1360#discussion_r945794575 ## libminifi/include/c2/C2Client.h: ## @@ -77,7 +77,7 @@ class C2Client : public core::Flow, public state::response::NodeReporter { bool initialized_ =

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1360: MINIFICPP-1853 Enable multiple metrics from the same processor type

2022-08-15 Thread GitBox
szaszm commented on code in PR #1360: URL: https://github.com/apache/nifi-minifi-cpp/pull/1360#discussion_r945783111 ## libminifi/src/core/state/nodes/ResponseNodeLoader.cpp: ## @@ -59,17 +59,17 @@ void ResponseNodeLoader::initializeComponentMetrics(core::ProcessGroup* root) {

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1360: MINIFICPP-1853 Enable multiple metrics from the same processor type

2022-08-03 Thread GitBox
szaszm commented on code in PR #1360: URL: https://github.com/apache/nifi-minifi-cpp/pull/1360#discussion_r925855542 ## C2.md: ## @@ -55,48 +58,49 @@ With this change, heartbeat with agent manifest included is sent only for the fi light weight heartbeat. If for some reason