[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

2022-08-17 Thread GitBox
szaszm commented on code in PR #1377: URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r947874627 ## libminifi/test/unit/ExpectedTest.cpp: ## @@ -52,7 +52,7 @@ TEST_CASE("expected map", "[expected][map]") { { const nonstd::expected e = 21; -auto

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

2022-08-17 Thread GitBox
szaszm commented on code in PR #1377: URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r941415079 ## libminifi/src/c2/C2Agent.cpp: ## @@ -739,7 +739,7 @@ utils::TaskRescheduleInfo C2Agent::produce() { std::make_move_iterator(payload_batch.end()),