[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093130269 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-02-01 Thread via GitHub
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1093130269 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start

2023-01-26 Thread via GitHub
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088076713 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded();