[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1

szaszm commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1246256189 ## extensions/standard-processors/processors/HashContent.h: ## @@ -49,21 +48,25 @@ namespace { // NOLINT HashReturnType ret_val; ret_val.second = 0;

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1

szaszm commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1229788131 ## README.md: ## @@ -151,6 +151,10 @@ and rebuild. * Lua and development headers -- Required if Lua support is enabled * libgps-dev -- Required if building

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1

szaszm commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1222987263 ## NOTICE: ## Review Comment: Could you update the copyright year near the top? ## bootstrap.sh: ## @@ -338,6 +338,9 @@ add_option

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1

szaszm commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1222986101 ## README.md: ## @@ -151,6 +151,10 @@ and rebuild. * Lua and development headers -- Required if Lua support is enabled * libgps-dev -- Required if building