[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1584: MINIFICPP-1755 - Use std::span instead of gsl::span

szaszm commented on code in PR #1584: URL: https://github.com/apache/nifi-minifi-cpp/pull/1584#discussion_r1246939583 ## libminifi/src/utils/LineByLineInputOutputStreamCallback.cpp: ## @@ -67,7 +68,7 @@ void LineByLineInputOutputStreamCallback::readLine() { if (end_of_line

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1584: MINIFICPP-1755 - Use std::span instead of gsl::span

szaszm commented on code in PR #1584: URL: https://github.com/apache/nifi-minifi-cpp/pull/1584#discussion_r1229570316 ## libminifi/include/utils/gsl.h: ## @@ -17,6 +17,7 @@ #pragma once +#include Review Comment: Now that the utils were moved, do we need this include?

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1584: MINIFICPP-1755 - Use std::span instead of gsl::span

szaszm commented on code in PR #1584: URL: https://github.com/apache/nifi-minifi-cpp/pull/1584#discussion_r1222182466 ## libminifi/include/utils/crypto/ciphers/Aes256Ecb.h: ## @@ -50,8 +50,8 @@ class Aes256EcbCipher { static constexpr size_t KEY_SIZE = 32; explicit