[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1246671763 ## docker/test/integration/features/MiNiFi_integration_test_driver.py: ## @@ -53,9 +53,9 @@ def __init__(self, context, feature_id: str): self.cluster.

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1246669182 ## docker/test/integration/cluster/containers/MinifiContainer.py: ## @@ -109,12 +110,16 @@ def _create_properties(self): if not self.options.enable_

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r124838 ## docker/test/integration/cluster/checkers/PrometheusChecker.py: ## @@ -18,7 +18,16 @@ class PrometheusChecker: def __init__(self): -self.promet

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-20 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1228023558 ## docker/test/integration/cluster/checkers/PrometheusChecker.py: ## @@ -18,7 +18,16 @@ class PrometheusChecker: def __init__(self): -self.promet