[GitHub] [nifi-minifi-cpp] szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-02-10 Thread GitBox
szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#issuecomment-584180260 Both appveyor test failures are unrelated: * ProcessorTests: Fails because it tests that a file with a name s

[GitHub] [nifi-minifi-cpp] szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-02-07 Thread GitBox
szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#issuecomment-583369678 > Will run tests. @bakaid Did you run the tests? ---

[GitHub] [nifi-minifi-cpp] szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#issuecomment-576289051 What is your opinion on using `const` by default? Pros: * extra static analysis -> bugs caught earlier