Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
removed atomic_load, atomic_store as they are problematic w/ gcc 4.8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
rebased pr, fixed http get integration tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@phrocker I've added atomic load and store to the logger and loggerimpl
classes and a pattern option to minifi-log.properties along with some
alternative patterns and a link to the spdlog
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@brosander yeah I think an atomic would solve the problem.
yeah, I think the pattern would be cool.
---
If your project is set up for it, you can reply to this email and have you
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@phrocker
For your first point about reinitializing logging while a flow is running,
is it worth it to switch the delegate reference on the Logger to an atomic?
Second po
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
This is good stuff. I'm taking a look
General comments before I dive in. Did we lose the ability to change the
logger format real time? If there was an issue in production and we ha
