[GitHub] nifi-minifi-cpp issue #107: MINIFI-262: Configuration listener

2017-06-07 Thread benqiu2016
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/107 @phrocker https://github.com/apache/nifi-minifi-cpp/pull/112 for a single commit close this one for now --- If your project is set up for it, you can reply to this email and

[GitHub] nifi-minifi-cpp issue #107: MINIFI-262: Configuration listener

2017-06-07 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/107 +1 @benqiu2016 Thanks for the update. Would you mind squashing your commits with a message you would like to include before we merge it? --- If your project is set up for it,

[GitHub] nifi-minifi-cpp issue #107: MINIFI-262: Configuration listener

2017-06-06 Thread benqiu2016
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/107 @phrocker add test case, use condition variable, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi-minifi-cpp issue #107: MINIFI-262: Configuration listener

2017-06-05 Thread benqiu2016
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/107 @phrocker please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature