[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 @randerzander Great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-29 Thread randerzander
Github user randerzander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 I have opened https://issues.apache.org/jira/browse/MINIFI-111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 Thanks! Just makes it a little easier to cover as that one was closed out. Much appreciated. Was able to reproduce on a Linux environment. --- If your project is set up for it, you can repl

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-29 Thread randerzander
Github user randerzander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 Will do. I assumed you would have considered it part of the original ExecuteProcess jira. Will reply here shortly On Sep 29, 2016 9:21 AM, "Aldrin Piri" wrote: hey @

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 hey @randerzander would you mind please opening a ticket in JIRA to report this so we can track appropriately? https://issues.apache.org/jira/browse/MINIFI --- If your project is set up for

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-28 Thread randerzander
Github user randerzander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 @benqiu2016 @apiri saw that this got committed to master. Unfortunately, I'm getting build errors that strcpy and strtok are not members of 'std'. Including some build environmen

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-28 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 @benqiu2016 Looks good here! Will merge in and thanks for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-27 Thread benqiu2016
Github user benqiu2016 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 @apiri Address the above review comments. Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] nifi-minifi-cpp issue #13: MINIFI-109: Add ExecuteProcess

2016-09-27 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/13 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if