[GitHub] nifi-minifi-cpp issue #142: MINIFI-372: Replace leveldb with RocksDB

2017-10-16 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/142 @phrocker overall looks good, please remove the test and doc and unneeded stuff from the rocksdb source. ---

[GitHub] nifi-minifi-cpp issue #142: MINIFI-372: Replace leveldb with RocksDB

2017-10-09 Thread jdye64
Github user jdye64 commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/142 @phrocker this was a big one. Sorry it took so long to work but with the changes wanted to test several things. The PR looks good to me in its current state and will commit in a few minutes.

[GitHub] nifi-minifi-cpp issue #142: MINIFI-372: Replace leveldb with RocksDB

2017-10-08 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/142 @minifirocks and @jdye64 I've re-opened this since I found an issue that I wanted to clean up in the previous PR ---