[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-26 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @minifirocks merging now. I'll take care of the conflict when merging since it's a single line change in the readme. ---

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 refactor to use lib archive extension. ---

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-25 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @apiri @phrocker fix the test cast, change size and offset signature to uint6_t, it looks like travis passed. please review ---

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-24 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @minifirocks Given that we have a need for files bigger than 4gb, we should change all to uint64_t OR the preferred size_t ---

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-24 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @phrocker the basic class is io::BaseStream, the signature is virtual void seek(uint32_t offset) { the uint64_t break the virtual inheritance. CompressContext test is running on i

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-24 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 @minifirocks Can you provide some context regarding "the seek issue in stream?" I only see that you changed the variable from a uint64_t to a uint32_t. This reduces the file size

[GitHub] nifi-minifi-cpp issue #151: MINIFICPP-264: CompressContent Processor

2017-10-23 Thread minifirocks
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/151 implement the compress content, tested with random 100K payload with format gzip, bzip, lzma, xy-lzma. fix the seek issue in stream. ---