[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

2017-11-21 Thread calebj
Github user calebj commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/199 I'm too late, but removing the `CATCH_CONFIG_MAIN` and linking to `${CATCH_MAIN_LIB}` instead would be mode consistent with the other extensions' test creation script. I'll put that into #168

[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

2017-11-21 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/199 changes look good, will merge ---

[GitHub] nifi-minifi-cpp issue #199: MINIFICPP-316: Fix GPS tests and resolve linter ...

2017-11-21 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/199 reviewing ---