Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@apiri This was merged on the basis of "I'll provide an implicit agreement
to move forward." MINIFICPP-577 has been created to refactor the Property
constructor to reduce the # of argu
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
It looks like this went in before we had outstanding items tended to, the
least of which would be an issue which I do not currently see in JIRA. We
should either get those tasks captured/logg
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@phrocker Please elaborate what exactly your issues are. As you can see
from 20 days ago, all concerns were addressed to the best of my knowledge.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@phrocker I missed those when they got folded up by the GitHub view.
Apologies for that.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@achristianson and @apiri I don't believe the requests made in these pull
requests were ever responded to. It includes this PR and two others that are
all the same commits, just layered. I'
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@achristianson would you mind rebasing this one last time so we can merge
it in?
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Fixed.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Looks like some conflict(s) cropped up. Taking a look.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@achristianson I've seen that when there are port collisions in tests. I've
made https://issues.apache.org/jira/browse/MINIFICPP-518 and will take a look.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Build fail looks unrelated.
---
10 matches
Mail list logo
