[GitHub] nifi-minifi-cpp issue #378: MINFICIPP-568: Change resp to componentmanifest

2018-07-24 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/378 code changes look good. verified manifest functionality using minifi controller. will get this merged. ---

[GitHub] nifi-minifi-cpp issue #378: MINFICIPP-568: Change resp to componentmanifest

2018-07-23 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/378 reviewing ---

[GitHub] nifi-minifi-cpp issue #378: MINFICIPP-568: Change resp to componentmanifest

2018-07-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/378 For any reviewer note that this is a dependency for MINIFICPP-569, as such the structure needs to change. I've decided to make a change tonight to create a short term patch to the issue.