Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
All right, did some more poking around and looks good. Think we are good
to get this rolled in. Thanks again for all the efforts.
---
If your project is set up for it, you can reply to this
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
@apiri FYI the test protocol I used was to test s2s, bidirectionally, in
secure and non-secure mode. I tested in linux and under mac. It inspired me to
try and build an integration test
--
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
@apiri I tested it locally. I would like to add tests for it in unit tests
ala the java client. That may require a little bit more work though to stand up
a server, but that will be a subseq
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
Hey @phrocker, for the most part things look good. Thanks for going
through the tedium to get everything a bit more consistent. Overall, nothing
worth holding things up and protracting the PR
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/54
Due to the size of this PR I'm submitting it in hopes of continuing tests
on TLS and submitting that as a separate commit before merge.
---
If your project is set up for it, you can reply
