[GitHub] nifi-minifi-cpp issue #86: MINIFI-282: Move Socket tests and remove includes

2017-04-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/86 @phrocker no need for apologies was just covering bases with the Travis CI build failing. Re based off of this and am adapting the work I was going for 84 but haven't had he chance to finish ye

[GitHub] nifi-minifi-cpp issue #86: MINIFI-282: Move Socket tests and remove includes

2017-04-29 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/86 @apiri yeah sorry it was not intended to take the place of #84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] nifi-minifi-cpp issue #86: MINIFI-282: Move Socket tests and remove includes

2017-04-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/86 changes look good and verified build on os x and centos. this still has the issue that should be solved by #84. regardless, will get these changes incorporated. Thanks! --- If your project

[GitHub] nifi-minifi-cpp issue #86: MINIFI-282: Move Socket tests and remove includes

2017-04-29 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/86 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if