Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/91
build works, ran some simple integration flows. code changes look good.
thanks for the refactoring, this should be quite helpful moving forward!
will get this merged shortly
---
If
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/91
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/91
Thanks for feedback, changed those back and am rerunning build/tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/91
Looks good overall. I'm gonna take another pass through it in a bit with
some more caffeinated eyes.
---
If your project is set up for it, you can reply to this email and have your
reply a
