Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/158
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147858619
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.h ---
@@ -0,0 +1,197 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147858577
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.h ---
@@ -0,0 +1,197 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147858210
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.h ---
@@ -0,0 +1,197 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147858185
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,310 @@
+/**
--- End diff --
this HTTPProtocol
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857772
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,310 @@
+/**
--- End diff --
General organizational
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857668
--- Diff: extensions/http-curl/protocols/RESTSender.h ---
@@ -22,12 +22,13 @@
#include "json/writer.h"
#include
#include
+
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857566
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -204,7 +264,9 @@ const char *HTTPClient::getContentType() {
}
const
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857498
--- Diff: extensions/http-curl/protocols/RESTSender.h ---
@@ -22,12 +22,13 @@
#include "json/writer.h"
#include
#include
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857146
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -33,6 +33,7 @@
#include
#include
+#include
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857113
--- Diff: extensions/http-curl/processors/InvokeHTTP.h ---
@@ -23,14 +23,14 @@
#include
#include
+#include
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147857037
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -33,6 +33,7 @@
#include
#include
+#include
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147855801
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -204,7 +264,9 @@ const char *HTTPClient::getContentType() {
}
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147855769
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -204,7 +264,9 @@ const char *HTTPClient::getContentType() {
}
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147838696
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,312 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147837447
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,312 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147837310
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,312 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147837119
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -0,0 +1,312 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147749615
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147747069
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147740763
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147739749
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147739186
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147738287
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user minifirocks commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147738083
--- Diff: extensions/http-curl/client/HTTPCallback.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147542584
--- Diff: libminifi/test/curl-tests/sitetositehttp/HTTPHandlers.h ---
@@ -0,0 +1,322 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147542555
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -175,19 +201,53 @@ bool HTTPClient::submit() {
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158
MINIFICPP-60: Add initial implementation of Site to Site changes.
MINIFICPP-60: Update interfaces to allow for seamless extension
MINIFICPP-60: Update functions to accomodate
28 matches
Mail list logo
