[GitHub] nifi-minifi-cpp pull request #168: MINIFICPP-280 Move extension tests and te...

2017-12-01 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r154417158 --- Diff: extensions/http-curl/client/HTTPClient.cpp --- @@ -87,26 +89,17 @@ HTTPClient::HTTPClient() } HTTPClient::~HTTPClient() {

[GitHub] nifi-minifi-cpp pull request #168: MINIFICPP-280 Move extension tests and te...

2017-11-28 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r153562525 --- Diff: .travis.yml --- @@ -21,7 +21,7 @@ cache: timeout: 300 env: - CMAKE_BUILD_OPTIONS="-DENABLE_PCAP=TRUE" + CMAK