[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/279 ---

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-14 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/279#discussion_r174459253 --- Diff: extensions/http-curl/client/HTTPClient.cpp --- @@ -334,6 +334,8 @@ void HTTPClient::configure_secure_connection(CURL *http_session) {

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-14 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/279#discussion_r174445579 --- Diff: extensions/http-curl/client/HTTPClient.cpp --- @@ -334,6 +334,8 @@ void HTTPClient::configure_secure_connection(CURL *http_session) {

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-14 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/279#discussion_r174443984 --- Diff: extensions/http-curl/client/HTTPClient.cpp --- @@ -334,6 +334,8 @@ void HTTPClient::configure_secure_connection(CURL *http_session) {

[GitHub] nifi-minifi-cpp pull request #279: Minificpp 424

2018-03-13 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/279 Minificpp 424 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following