[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102507602 --- Diff: include/spdlog/sinks/wincolor_sink.h --- @@ -0,0 +1,116 @@ +// +// Copyright(c) 2016 spdlog --- End diff -- thanks!

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102499834 --- Diff: include/spdlog/sinks/msvc_sink.h --- @@ -0,0 +1,50 @@ +// +// Copyright(c) 2016 Alexander Dalshov. --- End diff -- Also s

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102500478 --- Diff: include/spdlog/sinks/wincolor_sink.h --- @@ -0,0 +1,116 @@ +// +// Copyright(c) 2016 spdlog --- End diff -- LICENSE adjus

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102499682 --- Diff: include/spdlog/sinks/dist_sink.h --- @@ -0,0 +1,71 @@ +// +// Copyright (c) 2015 David Schury, Gabi Melman --- End diff --

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102499389 --- Diff: include/spdlog/sinks/ansicolor_sink.h --- @@ -0,0 +1,116 @@ +// +// Copyright(c) 2016 Kevin M. Godby (a modified version by spdlog).

[GitHub] nifi-minifi-cpp pull request #55: MINIFI-222: Upgrade spdlog to latest relea...

2017-02-22 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/55 MINIFI-222: Upgrade spdlog to latest release. Modified Logger so that it removed the previously required flush argument. Copyright headers changed but copyright license is the same.