Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107930194
--- Diff: thirdparty/google-styleguide/cppguide.html ---
@@ -0,0 +1,6170 @@
+
--- End diff --
Agreed. Will change this.
---
If yo
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107926105
--- Diff: thirdparty/google-styleguide/cppguide.html ---
@@ -0,0 +1,6170 @@
+
--- End diff --
Should likely just link to this in docs s
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107926443
--- Diff: thirdparty/google-styleguide/eclipse-cpp-google-style.xml ---
@@ -0,0 +1,167 @@
+
--- End diff --
Might also want to just lin
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69#discussion_r107925513
--- Diff: thirdparty/google-styleguide/cpplint.py ---
@@ -0,0 +1,6154 @@
+#!/usr/bin/env python
--- End diff --
We will need to capture
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/69
MINIFI-225: Add Linter for Google style guide
Please provide feedback for this approach.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to s
