Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114543586
--- Diff: libminifi/test/unit/YamlCongifurationTests.cpp ---
@@ -0,0 +1,182 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114469266
--- Diff: libminifi/test/unit/YamlCongifurationTests.cpp ---
@@ -0,0 +1,182 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114377473
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114377308
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114376703
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114375962
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114375744
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114374896
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114371075
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114367613
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114364384
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114363142
--- Diff: libminifi/test/unit/YamlCongifurationTests.cpp ---
@@ -0,0 +1,182 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114362748
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137427
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137339
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138828
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137644
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138730
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137733
--- Diff: libminifi/test/unit/YamlCongifurationTests.cpp ---
@@ -0,0 +1,182 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138536
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -491,14 +510,18 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode,
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137974
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml(
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138774
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85
MINIFI-275 Bugfix for YAML Configs without Component IDs
This commit fixes a bug in which loading config YAML that did not
specify IDs (UUIDs) for components caused an exception. The
24 matches
Mail list logo