[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117081374 --- Diff: LICENSE --- @@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. The views and conclusions contained in the software and

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117080960 --- Diff: libminifi/src/core/Processor.cpp --- @@ -194,52 +193,10 @@ void Processor::removeConnection(std::shared_ptr conn) { } }

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117079885 --- Diff: LICENSE --- @@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. The views and conclusions contained in the software and

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117079731 --- Diff: libminifi/src/core/Processor.cpp --- @@ -194,52 +193,10 @@ void Processor::removeConnection(std::shared_ptr conn) { } }

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117079682 --- Diff: LICENSE --- @@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. The views and conclusions contained in the software and

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117076765 --- Diff: libminifi/src/core/Processor.cpp --- @@ -194,52 +193,10 @@ void Processor::removeConnection(std::shared_ptr conn) { } }

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/99#discussion_r117076182 --- Diff: LICENSE --- @@ -401,6 +401,33 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. The views and conclusions contained in the software and

[GitHub] nifi-minifi-cpp pull request #99: MINIFI-270: Move Base RPG capabilities bac...

2017-05-17 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/99 MINIFI-270: Move Base RPG capabilities back into RemoteProcessGroupPort This allows us to extend capabilities in RPG into other classes. Since the same basic functions are the same we