[GitHub] nifi-registry issue #18: NIFIREG-32: Add delete as available action for acce...

2017-10-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/18 Thanks @kevdoran , this all looks good, verified I was able to delete policies and see the change in permissions take place, I'll go ahead and merge ---

[GitHub] nifi-registry issue #18: NIFIREG-32: Add delete as available action for acce...

2017-10-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/18 In testing a bug was found when creating new users and groups through the API. The new commit fixes that issue. Feel free to squash on merge. ---

[GitHub] nifi-registry issue #18: NIFIREG-32: Add delete as available action for acce...

2017-10-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/18 I rebased and fixed the failing tests. @bbende can you please give it another look when you get a chance? ---

[GitHub] nifi-registry issue #18: NIFIREG-32: Add delete as available action for acce...

2017-10-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/18 Thanks @bbende, I'll rebase my branch and fix the tests ---

[GitHub] nifi-registry issue #18: NIFIREG-32: Add delete as available action for acce...

2017-10-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/18 After rebasing this against master, there are two test failures, I think its because one of the methods being mocked was modified slightly in my last PR ---