Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1002
Per a discussion with @trixpan, I offered to make the final change and add
the commit when merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1002
@joewitt hopefully last commit addresses your feedback. Mind having another
look?
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1002
@trixpan from DRY/readability perspective consider creating the builder
ahead of the if/else. So an alternative approach would look like this
(formatting aside)
`
Va
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1002
@joewitt this commit is quite small (intent is just aesthetics / UX) but
ventures into waters I don't usually sail... Would you mind having a look?
I thank you in advance
---
If your project