Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1042
I added server- and client-side modifications to pre-authorize the system
diagnostics API call, and removed the unnecessary error handling code.
---
If your project is set up for it, you can reply to
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
@jvwing While reviewing I stumbled into an existing bug filtering the
tables in the cluster page. I've addressed it here [1]. Hoping you could just
review what I did so I could include it in your PR.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1042
@mcgilman Your changes look good to me. I had noticed that filter
behavior, but I wasn't sure how intentional it was. Your fix does allow
filtering by the full address or status text as displayed, ra
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
@jvwing I'll just squash those changes into your commit before I push. Just
wanted to communicate before I do that. Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
@jvwing Just finished up testing and everything looks good. This has been
merged to master. I did find another minor issue with sorting the table but I
updated the sort method accordingly. Thanks!
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1042
Thank you, @mcgilman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
