Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1050
@ijokarumawak Done. Thanks again for your great review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1050
I confirmed that my comments are addressed. Please squash the commits then
I'll merge it.
Thanks @pvillard31 !!
---
If your project is set up for it, you can reply to this email and have you
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1050
Thanks @ijokarumawak for this review. I think I've addressed your comments,
let me know if you want me to squash the commits.
---
If your project is set up for it, you can reply to this email and
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1050
Thanks @pvillard31 this enhancement would be useful!
I reviewed the change and played with unit tests, and found 3 comments I'd
like to share.
### 1. Change of default behavior