Github user combineads commented on the issue:
https://github.com/apache/nifi/pull/1101
@mattyb149
Sorry to bother you again. I changed the commit message.
Thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1101
Looking good, I will give this a try. However the commit that updated the
unit test seems to have a title that came from a different PR/Jira case, do you
mind changing the name of the commit to be m
Github user combineads commented on the issue:
https://github.com/apache/nifi/pull/1101
@mattyb149
I changed the initial.maxvalue.CREATED_ON attribute of
testInitialMaxValue() test.
Thanks for your review.
---
If your project is set up for it, you can reply to this email and
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1101
Can you add a unit test for this? One option is to update the
testInitialMaxValue() test to change the name of the "created_on" column to
uppercase, as well as the max-value column name and the
ini
Github user combineads commented on the issue:
https://github.com/apache/nifi/pull/1101
Hello, @mattyb149 .
Cloud you review this PR?
Thank you for your effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
