[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 Worked through a couple of iterations to get it to display properly. Will apply another commit onto the branches and include the close statement there. --- If your project is set up for it, you can

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 @trixpan Actually just tried to test this and it didn't render appropriately. Maybe the ASL comment needs to be Markdown style as opposed to the XML version? --- If your project is set up for it,

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 Ah drat, forgot to update the commit with the "This closes..." Going to need a template to stop me from making reviewer mistakes 🤕 . Could you please close this out? I merged to both master

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 Andre, looks good with the fixes. I noticed a few typos but I shall fix those up for you and get this merged in. Thanks for taking the time to do this! Should be a great help. --- If your project

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 @apiri - hopefully addressed most of the typos and comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 No worries! 😄 Teamwork makes the dream work. Just thankful you took the time to put something into VI. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 OMG... that's what happens when someone decides to type text into vi by 1AM... :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1103 Completely okay! I had started typing a letter up to the community that has been sitting in my drafts folder. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 @apiri I know this ticket is assigned to you but given I suspect how busy your side of the ocean is, I thought I would give it a go and try to help. Let me know if that is not ok and I will