[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-18 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1137 Built with `contrib-check`, all tests pass (Mac OS X 10.11.6, GNU bash, version 4.3.42(1)-release (x86_64-apple-darwin15.0.0), Java 1.8.0_101). Created a symlink to `bin/nifi.sh` in another director

[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-18 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1137 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1137 Indeed. Yet, as discussed in the original stackoverflow thread, the shell approach is greatly portable and eliminate the need to have any of the external utils. At least we didn't e

[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-14 Thread jfrazee
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1137 @trixpan Thanks for picking this up again! Since this is just about variation in the arguments that readlink supports or the availability of realpath, I would have thought it'd just be simpler to have

[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1137 From my tests, path finding seems to work well: ``` [trixpan@development init.d]$ ls -l nifi lrwxrwxrwx 1 root root 34 Oct 14 15:02 nifi -> /home/trixpan/development/nifi.sh [trixp

[GitHub] nifi issue #1137: NIFI-1710 - Resolve path name to nifi.sh script

2016-10-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1137 @jfrazee @arpitgupta @busbey Since PR#315 got stalled, I reworked from scratch. Would appreciate your feedback if this solves the problem reported on NIFI-1710 @apiri @Yolan