Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1151
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1151
Personally, I think if we're going to attempt to draw a preview of the
processor block we need to fill in some of the empty space. Can we try putting
in the name of the processor and drawing the two
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1151
Could be...I was also thinking about how this maps to the Label
preview...likewhy do we show any text if the label doesn't have text
currently?
---
If your project is set up for it, you can
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1151
Thanks @scottyaslan â agree on getting @mcgilman 's opinion too. Perhaps
it's just that initial color choice I'm not fond of. It's fine applied to the
processor icon, but at a larger scale it's reall
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1151
@moranr I have updated this PR to include the changes you have suggested
for the Label fill color preview and wording.
As for the initial preview I would like to get @mcgilman opinion but
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1151
@scottyaslan, @mcgilman â I think the processor preview looks good,
showing only what will change. For me, what is odd is the fact that the initial
preview is not an accurate view of the current stat
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1151
@mcgilman I have updated the fill color dialog processor preview to match
what will actually be applied to the element on the canvas. I also updated the
label text to contrast the fill color for t
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1151
Looks good @scottyaslan. But I think we need to update the Fill Color
dialog so the user can see a preview of their color choice with the contrasting
color.
---
If your project is set up for it, yo
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1151
Will review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
