Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1184
@olegz Thank you very much! I hope it will be helpful for users and willing
to improve it over time!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1184
@ijokarumawak at this point I am going to say Great work! I am sure in
month to come there will be things ti improve as people start using it , but
LGTM for now. Will merge shortly!
---
If your projec
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1184
Koji, this is great and I'll be looking at it shortly with hopes of merging
it some time today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1184
@olegz Thanks again for the great review! I rebased the PR and done
additional refactoring based on your feedback. Please let me know if you prefer
it to be squashed for further review process.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1184
@olegz Thanks for taking time to review! I added a commit to address your
feedback. Also, I've added `displayName` to the property descriptors those were
added in this PR.
---
If your project i
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1184
Hello NiFi developers,
This PR contains a new set of WebSocket support components.
At least there're two WebSocket processors available on GitHub already,
[nifi-websocket](https: