[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-19 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1236 @mcgilman @ijokarumawak squashing and merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-18 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1236 @mcgilman Thanks for updating the docs! Exception handling at shutdown looks good. +1 Would you squash the commits to get it merged? --- If your project is set up for it, you can reply to

[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-18 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1236 I am +1 now. If @ijokarumawak has no issues let's merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1236 Good call. I've updated the Admin Guide in a second commit. Thanks @ijokarumawak! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1236 I tested it with OpenLDAP - Tested the default behavior, DN was used as NiFi user identifier - Tested with USE_USERNAME, the username which was input at the login window was used as

[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users

2016-11-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1236 Reviewing.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or