[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-18 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-18 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 I'm getting some errors when running the standard test suite. Did configuration requirements change for this? ``` Results : Failed tests: TestPutTcpSSL>TestPutTCPCom

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-18 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 There is an issue in `master` where the `nifi-app.log` is spammed with the following lines: ``` 2016-11-18 17:39:14,053 ERROR [Cleanup Archive for default] o.a.n.c.repository.FileSystem

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-19 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 The issues with cleaning the content_repository were local to my machine. I resolved those with @markap14 's help. Now I set up two client certificates and two user identities -- myself and "Matt".

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1247 Thanks for the review @alopresto! I should be able to update this PR with all the of the suggestions and code comments. --- If your project is set up for it, you can reply to this email and have you

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1247 I worked through the majority of the recommendations. However, I think it makes sense to hold off on adding anything to the description area of the New Component Dialogs. We likely need to reconsider

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 Checked out the new changes. I like it. Thanks Matt. Verified that existing restricted processors show indicator icon on canvas: https://cloud.githubusercontent.com/assets/798465/20

[GitHub] nifi issue #1247: Introducing restricted components which require additional...

2016-11-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1247 I'm just running the `contrib-check` and tests now. Once those pass, I'll provide a +1 and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi