[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user skrewz commented on the issue: https://github.com/apache/nifi/pull/1302 Great. Happy to help. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1302 I fixed a small checkstyle issue but otherwise this was great. Verified that running with an encrypted `nifi.properties` file worked and the master key value was read from `conf/bootstrap.conf` to

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user skrewz commented on the issue: https://github.com/apache/nifi/pull/1302 As-of 2c5d5fd, reckon we're good. Feedback welcome, @alopresto and others. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user skrewz commented on the issue: https://github.com/apache/nifi/pull/1302 I reckon I'll have a look into this tomorrow. Sorry about the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1302 Hi @skrewz just checking in to see if you need any assistance or if it's just been a matter of bandwidth on this. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1302 @skrewz Yes, please make the changes and then as @apiri mentioned just push to the same branch and the PR will update automatically. Thanks for the quick response to my comments. Sorry again for

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1302 @skrewz You can just push to the same branch that this PR was made from and GitHub has you covered from there. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user skrewz commented on the issue: https://github.com/apache/nifi/pull/1302 So, ehm. Should I remedy the above, and ehm---haven't done GitHub pull requests before---update the pull request or how does this work? :) --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1302 @trixpan @skrewz I wrote up a bunch of comments on this a week ago but the new GitHub "review" process didn't post them until I "confirmed" them just now. Sorry about that. --- If your project

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1302 Yeah, revisiting this. Sorry, was out of the country for a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1302 @alopresto ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if