[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1384 Thanks @pvillard31. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1384 Thanks for the review @mcgilman and @andrewmlim ! I changed the wording in the confirmation dialog and pushed another commit to address reporting tasks. --- If your project is set up for it, y

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread andrewmlim
Github user andrewmlim commented on the issue: https://github.com/apache/nifi/pull/1384 Thanks for your work here @pvillard31 ! I think the confirmation message should be changed to be consistent with what is done for template and rule deletion. So it should read: De

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1384 The code changes look good. Will have @andrewmlim review as well since he created the JIRA. May need to update some wording for consistency throughout the application. For instance, template deletion

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1384 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if