[GitHub] nifi issue #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL

2017-10-05 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1471 +1 LGTM, Ran unit tests and contrib-check, also tested with a MySQL stored procedure returning 2 ResultSets, verified two flow files were output, each with the correct row count attribute. Thanks fo

[GitHub] nifi issue #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL

2017-10-04 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/1471 @mattyb149 Sounds good. I've committed the change. ---

[GitHub] nifi issue #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL

2017-10-03 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/1471 @mattyb149 I've rebased and squashed things down. I still don't have a good test case; as mentioned before stored procedures aren't so easy in Derby. Would still like to see this get in. -

[GitHub] nifi issue #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL

2017-02-14 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/1471 @mattyb149 I generally use ExecuteSQL to call Stored Procedures. Unfortunately Stored Procedures are such a pain in Derby it was easier to build a test that called an update statement. Howe

[GitHub] nifi issue #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL

2017-02-14 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1471 I just noticed in the added unit test that one of the examples of a "query" that returns no ResultSets is an "UPDATE". Are you proposing that ExecuteSQL be able to handle these kinds of statements?