Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/1481
Closed by commit
[4f72e34](https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=4f72e3491f2372c8c45afb96a765c1f5cdd2f07d).
Thanks @mosermw!
---
If your project is set up for it, you can
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1481
@mosermw ohhh. wasn't aware of it. thanks for sharing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1481
@trixpan the "This closes" commit hook doesn't work on the 0.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1481
@markap14 I suspect the reason is @mosermw added the closure after the
signature and closure should come above sign-off-by?
---
If your project is set up for it, you can reply to this email and
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1481
@jskora not sure what's going on here, but it see a comment above that
asfgit pushed a commit that indicates that it closes this PR. But this PR is
still open. Can you close manually? Thanks!
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1481
Reviewed, along with #1475. Licensing concern about the code looks to be
resolved. +1 will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on
