Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/1541
I somehow missed that you updated, @trixpan . I'm reviewing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
@joewitt feedback should be addressed.
@trkurc - special thanks for the review and PR. I have been having been
able to commit enough resources to the project lately and your PR certainly
help
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/1541
@trixpan - was it intentional to not include the nars you built in the
assembly? The PR I'm reviewing doesn't have the nar versions in the root
pom.xml nor the nars in the dependency section of the ass
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/1541
I'll have some cycles to review this over the next few days
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
Good news! work has been "completed" and PR squashed and rebased to master.
Things to notice:
1. At this stage, test units are marked as ignore as they expect the
availability of a
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
processor logic is theoretically complete. Now finishing the IRC over TLS
logic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
also note that the easier way of setting up an IRC for testing is to spin
up miniircd, which works like a charm for basic testing
---
If your project is set up for it, you can reply to this email and
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1541
this PR still not ready to review, however given this is the first time I
am putting together a ControllerService I would appreciate some early feedback.
As you can see, design for the Consume
