[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-05-05 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1595 Reviewer consensus (see the Jira case for details) is to exclude the hdfs.error.code for now, rather than possibly reporting an incorrect cause of an IOException. Once we can tell the difference, we

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread jdye64
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/1595 My reasoning for adding the extra relationship was for end users to understand that certain directories or files had improper permissions and have a visible way to see that with the extra relationship.

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 From a first look the code seems ok but I have a quick question: Do we truly need a permission denied relationship? It seems like a deviation from the general nature of failure relationships (

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 Glad you managed to get the lines out of their conflict... 😀 will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread jdye64
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/1595 @trixpan refactoring due to NIFI-3204 #1561 which caused some conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 :rofl: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-10 Thread jdye64
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/1595 @trixpan I tried talking it out but that didn't seem to solve the conflict?? Will try more forceful procedures when I get off the road and near a computer ;) thanks for taking a look at this! --- If

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 @jdye64 can you please solve the conflicts? Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha