[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-18 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1619 changes look good, L looks correct for added deps. will get this merged, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-18 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1619 reviewing changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 no worries. rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-10 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1619 @trixpan sorry, been traveling and have had a bit of a hectic schedule. would you please be able to rebase and then I will look to get this closed out in the next day or so? --- If your project is

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 @apiri? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 @apiri - Added the note. Please certainly link to PerformanceConsider. As you may recall earlier this week while coding this processor I posted a message around the very same issue: It would be

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-03-31 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi/pull/1619 @trixpan the absence of streaming impls unfortunate 🙁 Could we please note this in a fashion similar to EvaluateJsonPath? Just would like it documented for those that make use of it. I'm

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-03-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 also, regarding Both underlying implementations use in memory objects. I found some pseudo stream ones but despite a method allowing streaming, the underlying calls still loaded the whole content in

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-03-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 Note: This PR also contain a minor typo correction to "logic independent" part of of ParseCEF processor. --- If your project is set up for it, you can reply to this email and have your reply appear